Bug 906

Summary:	Incorrect automap level names when using classic map style name
Product:	Odamex	Reporter:	RedZTag <jostol27>
Component:	Client	Assignee:	Odamex Bug Reporter <odamex-bug-reporter>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	alexmax2742
Priority:	P2
Version:	0.6.x
Hardware:	x86 (Windows, Linux, etc)
OS:	Windows

Description RedZTag 2012-10-02 05:06:59 UTC

Using Odamex - 0.6.1 for Windows, from the .zip package.
OS is Windows 7 Home Premium. Odamex is running in single player mode.
I'm assuming it's the same for all other operating systems and Odamex 1.6.1 distributions (and probably development builds too).

I am able to reproduce this bug with a fresh extraction from the zip with the only change to configuration is changing the automap style name to classic. This bug affects DooM 2 and Ultimate DooM (and shareware doom), TNT and Plutonia.
Unknown if it affects wads with dehacked patches and whatnot.

Evidence:
https://sites.google.com/site/jostol27/Odamex_COOP_20121002_173511.bmp
https://sites.google.com/site/jostol27/Odamex_SOLO_20121002_175453.bmp
https://sites.google.com/site/jostol27/Odamex_SOLO_20121002_175741.bmp
https://sites.google.com/site/jostol27/Odamex_SOLO_20121002_175901.bmp

Comment 1 Alexander Mayfield 2012-10-12 00:31:23 UTC

Committed a potential fix in r3380, please confirm.

Comment 2 RedZTag 2012-10-15 21:39:02 UTC

@Alexander Mayfield
Testing on Win7 yadda yadda yadda, Odamex revision 3383.

DooM II Level Names display correctly
Plutonia Level Names display correctly
TNT Level Names display correctly
Ultimate DooM Episode 1 Names display correctly


Problems with E2M1 to E4M9
Starting E2M1 will result in it saying E2M2, E2M2 as E2M3 etc
E3M1 will display E3M3, E3M2 as E3M4 etc
E4M1 will display E4M4, E4M2 as E4M5 etc E4M9 as Level 3: The Gauntlet




Questions: In Ultimate DooM is it supposed to display E1M1: Hangar instead of Level 1: Hangar 
???

Is classic map style name supposed to display level 1: entryway on pwads that change the level names? Because it currently does that.
Instead of like Level 1: Fortress Collision - ZDCTF01 
???

Comment 3 Alexander Mayfield 2012-10-17 02:08:27 UTC

Committed a fix for Ultimate Doom in r3387.  Please test.

As for the specific level names, we're grabbing them straight out of ZDoom's LANGUAGE lump from that time period.  I'm pretty sure they have fidelity to the original strings, with the addition of being able to be changed by DeHackEd.

Comment 4 RedZTag 2012-10-17 05:09:04 UTC

Testing with r3388, problem is solved in ultimate doom.
Dehacked patches do work on changing the level name.

The only problem left now is that MAPINFO doesn't change the level name on the classic style, only on odamex style.
map MAP01 "Fortress Collision - ZDCTF01"
Still displays Level 1: Entryway

Comment 5 Alexander Mayfield 2012-10-18 16:42:36 UTC

(In reply to comment #4)
> Testing with r3388, problem is solved in ultimate doom.
> Dehacked patches do work on changing the level name.
> 
> The only problem left now is that MAPINFO doesn't change the level name on the
> classic style, only on odamex style.
> map MAP01 "Fortress Collision - ZDCTF01"
> Still displays Level 1: Entryway

This is expected behavior.  The map names used by the Automap used to be hardcoded (thus why they required DeHackEd to replace), but when MAPINFO came along the map names were grabbed out of that lump instead.  In the case of no MAPINFO lump there are hardcoded MAPINFO entries inside Odamex itself that switch out based on which IWAD you are using.

When you are switching between the two automap name options, you are essentially switching between MAPINFO-provided names and DeHackEd-provided names.  There might be some clever way to unify the two systems.  How does ZDoom 2.xx handle it?

Comment 6 Mike Lightner 2012-12-14 23:05:11 UTC

The remaining behavior to be addressed is not a bug but an enhancement.  We will examine this again in the future if someone does not post an enhancement bug beforehand.  Marking fixed.