Bug 1083

Summary:	player downloading from server shows up as playing on the scoreboard
Product:	Odamex	Reporter:	mikaelhhome
Component:	Server & Client	Assignee:	Odamex Bug Reporter <odamex-bug-reporter>
Status:	NEW ---
Severity:	normal	CC:	grandpachuck187, mdvulture
Priority:	P1
Version:	0.7.x (Old)
Hardware:	All
OS:	All

Description mikaelhhome 2014-05-24 23:48:44 UTC

a player downloading from the server can sometimes show up as playing on the scoreboard. this takes up a spot in the server as well and can prevent people from playing in 1v1 servers
here is a demo showing it in a CTF game. take a look at when Bless[NS] starts downloading from server
https://www.dropbox.com/s/5glqhz3380jmgz0/Odamex_CTF_20140525_012713_%5Bfw%5Dnub_hat_idl2013.wad_MAP24.odd

Comment 1 Dr. Sean 2014-06-10 20:19:07 UTC

Normally when a downloading client connects, the server sends a message to all other clients to inform them that a new client joined and should be considered a spectator. A code change in 0.7.0 added a test to avoid telling the downloader that he is a spectator. However the test had a typo and always evaluated to "true", meaning that no clients were told to treat the downloader as a spectator and thus everyone treated the downloader as a non-spectating player.

r4989 fixes this. Please test and confirm.

Comment 2 HeX_Vulture 2017-01-09 21:05:28 UTC

[21:06] <@mrcrispy> also bug 1083
[21:06] <@mrcrispy> that one is only fixed until the map changes
[21:06] <@mrcrispy> then it happens again