Bug Tracker – Bug 1070

Odamex doesn't support plain-text (post ZDoom 1.23b33) LANGUAGE lump

Last modified: 2014-04-24 15:36:37 CDT
Bug 1070 - (ARRAY(0x53732d8)) Odamex doesn't support plain-text (post ZDoom 1.23b33) LANGUAGE lump
(ARRAY(0x53732d8))
Odamex doesn't support plain-text (post ZDoom 1.23b33) LANGUAGE lump
Status: NEW
Product: Odamex
Classification: Unclassified
Component: Server & Client
0.7.x
All All
: P1 major
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2014-04-12 01:01:09 CDT by Maëllig Desmottes
Modified: 2014-04-24 15:36 CDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maëllig Desmottes 2014-04-12 01:01:09 CDT
Odamex seems to use a custom "LANGUAGE" lump in order to translate the game into French, English, Italian, ... . If trying to read in a txt viewer seems to have binary data.

When using a custom "LANGUAGE" lump (from btsx_e1.wad for instance), Odamex will systematically crash the game/server saying:

> LANGUAGE had 25632 strings.
> This version of ZDoom expects it to have 575.
> GetLastError = 0

Those lumps should be viewable in plain text.
Comment 1 Dr. Sean 2014-04-12 16:32:17 CDT
Odamex does not currently support the plain-text language lump used in ZDoom 2.0.97 and above. The older language lump is in a compiled binary form and was used primarily in the 1.22 and 1.23b33 versions of ZDoom.

That said, Odamex should simply ignore language lumps that are not compatible instead of throwing I_FatalError.
Comment 2 Dr. Sean 2014-04-12 17:28:15 CDT
r4771 attempts to verify that the header in the binary LANGUAGE lump is legitimate. If it fails verification, the LANGUAGE lump is not loaded and a warning message is printed.
Comment 3 Dr. Sean 2014-04-24 15:36:37 CDT
I changed the title of the bug to reflect the issue more accurately.