Bug 1083 – player downloading from server shows up as playing on the scoreboard

Bug 1083 - (ARRAY(0x5174570)) player downloading from server shows up as playing on the scoreboard

(ARRAY(0x5174570))
Summary:	player downloading from server shows up as playing on the scoreboard

Status:	NEW

Product:	Odamex
Classification:	Unclassified
Component:	Server & Client
Version:	0.7.x
Hardware:	All All

Importance:	P1 normal

URL:

Depends on:
Blocks:
	Show dependency tree

Reported:	2014-05-24 23:48:44 CDT by mikaelhhome
Modified:	2017-01-09 21:05 CST (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description mikaelhhome 2014-05-24 23:48:44 CDT

a player downloading from the server can sometimes show up as playing on the scoreboard. this takes up a spot in the server as well and can prevent people from playing in 1v1 servers
here is a demo showing it in a CTF game. take a look at when Bless[NS] starts downloading from server
﷒0﷓

Comment 1 Dr. Sean 2014-06-10 20:19:07 CDT

Normally when a downloading client connects, the server sends a message to all other clients to inform them that a new client joined and should be considered a spectator. A code change in 0.7.0 added a test to avoid telling the downloader that he is a spectator. However the test had a typo and always evaluated to "true", meaning that no clients were told to treat the downloader as a spectator and thus everyone treated the downloader as a non-spectating player.

r4989 fixes this. Please test and confirm.

Comment 2 HeX_Vulture 2017-01-09 21:05:28 CST

[21:06] <&#64;mrcrispy> also bug 1083
[21:06] <&#64;mrcrispy> that one is only fixed until the map changes
[21:06] <&#64;mrcrispy> then it happens again