Bug Tracker – Bug 1197

Crash with vid_640x400 and a Border

Last modified: 2020-04-21 01:32:12 UTC
Bug 1197 - Crash with vid_640x400 and a Border
Summary: Crash with vid_640x400 and a Border
Status: NEW
Alias: None
Product: Odamex
Classification: Unclassified
Component: Client (show other bugs)
Version: 0.7.x (Old)
Hardware: All All
: P1 normal
Assignee: Odamex Bug Reporter
URL:
Depends on:
Blocks:
 
Reported: 2016-10-14 17:44 UTC by HeX_Vulture
Modified: 2020-04-21 01:32 UTC (History)
2 users (show)

See Also:

Attachments

Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description HeX_Vulture 2016-10-14 17:44:31 UTC
Join a game and hit - to make the screen have a green border, then apply vid_640x400 and odamex will crash.
Comment 1 Russell Rice 2016-11-11 19:30:40 UTC
r_plane.cpp:265 is where it crashes
Comment 2 HeX_Vulture 2019-01-06 01:02:18 UTC
still happens with SDL2 on January 5, 2019 with latest master
Comment 3 Dr. Sean 2020-04-21 01:32:12 UTC
This has been resolved in the 0.8.3 release candidate.

The global variable ST_Y is not correct when vid_320x200 or vid_640x400 is enabled, which causes the border drawing function to write past the end of the screen buffer. The function ST_StatusBarY() provides the correct value for top edge of the status bar.