Bug Tracker – Bug 1235

Vanilla demo recording problems

Last modified: 2019-01-16 17:30:59 CST
Bug 1235 - Vanilla demo recording problems
Summary: Vanilla demo recording problems
Status: NEW
Alias: None
Product: Odamex
Classification: Unclassified
Component: Client (show other bugs)
Version: 0.7.x
Hardware: All All
: P5 minor
Assignee: Odamex Bug Reporter
URL:
Depends on:
Blocks:
 
Reported: 2018-12-25 11:38 CST by Maëllig Desmottes
Modified: 2019-01-16 17:30 CST (History)
1 user (show)

See Also:

Attachments

Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maëllig Desmottes 2018-12-25 11:38:54 CST
When using Odamex.exe -record <demolmp> , moving the mouse to the left is resulting in harsher movements compared to the right, where it's immediate.

Hexen & Heretic suffered from this bug.

Attempting to fix it (with Chocodoom's way for instance) desyncs the demo (even on Odamex itself).
Comment 1 Maëllig Desmottes 2018-12-25 19:31:34 CST
In addition to that, I've found the following problems:

- Odamex records the jumping button while recording the demo (Vanilla doesn't support it)
- Odamex doesn't store the new weapon status when using nextweap / prevweap.
Comment 2 Maëllig Desmottes 2018-12-25 20:09:18 CST
After recording a demo, when I'm playbacking it, it also happened to see my demo being suddenly cut before going back to DEMO1.

Also, I found a way to fix the jerky mouse movement in shorttics, and to disallow the jump input.

Commit link : 
https://github.com/odamex/odamex/commit/a3132c5b75719245226147edfe207d5bc859fe0c
Comment 3 Maëllig Desmottes 2018-12-26 13:47:13 CST
After looking deep into the code, it was simply because Odamex didn't properly end the demo (I used "disconnect" before playbacking it).

Now, another bug seen : the game tries to throw an exception if you record a vanilla demo on an unknown map. 

Current pull request fixes all of these issues.
Comment 4 Maëllig Desmottes 2019-01-16 06:19:14 CST
IN CASE OF : All bugs above seem to be fixed.

However, one last bug I've found :

If you start a DOOM2 demo, then switch to a netdemo during the playback, the netdemo won't play, immediately starting the DEMO1 loop.
Comment 5 Maëllig Desmottes 2019-01-16 17:30:59 CST
This PR ( https://github.com/odamex/odamex/pull/34 ) fixes the problem lastly issued. If this is merged into the master branch, we'll close this ticket !