Bug Tracker – Bug 1266

Parsing mapinfo with invalid syntax can cause unexpected behavior

Last modified: 2019-02-11 19:39:26 UTC
Bug 1266 - Parsing mapinfo with invalid syntax can cause unexpected behavior
Summary: Parsing mapinfo with invalid syntax can cause unexpected behavior
Status: NEW
Alias: None
Product: Odamex
Classification: Unclassified
Component: Client (show other bugs)
Version: 0.8.x
Hardware: All All
: P5 normal
Assignee: Odamex Bug Reporter
URL:
Depends on:
Blocks:
 
Reported: 2019-02-11 19:39 UTC by Nick
Modified: 2019-02-11 19:39 UTC (History)
1 user (show)

See Also:

Attachments

Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick 2019-02-11 19:39:26 UTC
ParseMapInfoLower in g_level.cpp does not check for -1 that SC_MustMatchString will return on an invalid string. Because the function adds the return value to a pointer it will get set to an unexpected point in memory.