Bug Tracker – Bug 1302

Reloading a save that includes active Icon of Sin crashes

Last modified: 2020-01-14 18:22:26 UTC
Bug 1302 - Reloading a save that includes active Icon of Sin crashes
Summary: Reloading a save that includes active Icon of Sin crashes
Status: NEW
Alias: None
Product: Odamex
Classification: Unclassified
Component: Client (show other bugs)
Version: 0.8.x
Hardware: All Other
: P5 normal
Assignee: Odamex Bug Reporter
URL:
Depends on:
Blocks:
 
Reported: 2019-12-26 21:11 UTC by HeX_Vulture
Modified: 2020-01-14 18:22 UTC (History)
4 users (show)

See Also:

Attachments

icon of sin crash (326.45 KB, application/octet-stream)
2019-12-26 21:11 UTC, HeX_Vulture
Details
Save game seconds before a Cube spawns a mob (16.06 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-01-13 23:50 UTC, Terr
Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description HeX_Vulture 2019-12-26 21:11:35 UTC
Created attachment 579 [details]
icon of sin crash

Go to map30
activate icon of sin
let a cube spawn in
save the game
load the game
crash.

Crash log provided.
Comment 1 Terr 2020-01-13 23:50:32 UTC
Created attachment 581 [details]
Save game seconds before a Cube spawns a mob

Save game where a Cube is about to spawn a mob in front of the player
Comment 2 Terr 2020-01-13 23:56:01 UTC
I've narrowed down the cause but not a solution yet.

The moment a Cube spawns an enemy, it should have an AActorPtr for the target coordinates of where to spawn it. For some reason, this pointers is null after loading the save game -- triggering the crash (in `A_SpawnFly()`)

I haven't been able to check yet whether the target coordinates are saved for Cubes, or if they're just not initialized properly.
Comment 3 Terr 2020-01-14 07:00:50 UTC
I suddenly realized that the target of a Revenant's missile also doesn't survive and save and load, so this "bug" is not unique. It's just that a missile will just become non-homing and explode at some point. But what about the a Cube? Should we just remove it on load?
Comment 4 Maëllig Desmottes 2020-01-14 11:38:01 UTC
Given the data saved behaviour on Odamex tries to mimic Doom 2's at best, if it doesn't target anything, it's destroyed, and thus, seems entirely fine.

Just to track down stuff easily, here is Terr's PR : https://github.com/odamex/odamex/pull/109
Comment 5 Dr. Sean 2020-01-14 18:22:26 UTC
Merged into development branch.