Bug 475 – Servers aren't checking client wads

Bug 475 - (ARRAY(0x4a7bd98)) Servers aren't checking client wads

(ARRAY(0x4a7bd98))
Summary:	Servers aren't checking client wads

Status:	REOPENED

Product:	Odamex
Classification:	Unclassified
Component:	Server & Client
Version:	(old) 0.4
Hardware:	All All

Importance:	P2 major

URL:

Duplicates:	ARRAY(0x4ce6b98) (view as bug list)
Depends on:
Blocks:
	Show dependency tree

Reported:	2008-06-01 05:47:34 CDT by Ralph Vickers
Modified:	2012-04-13 08:28 CDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ralph Vickers 2008-06-01 05:47:34 CDT

Servers should make sure that clients are using the exact same wad files as the server. As of revision 870, this is not the case.

I began modifying my odamex.wad to test out new flag sprites. I soon found out that even with a modified odamex.wad I could connect to any server. 

Correct behavior is for server to check client's wad and make sure it matches exactly. If the wad doesn't match, player is booted from the server.

Comment 1 Ralph Vickers 2008-08-03 07:31:39 CDT

[10:00] <&#64;Ralphis> what if it was optional server side
[10:00] <&#64;Ralphis> so servers like odasvn can not check it which is useful for development
[10:01] <&#64;Ralphis> but it makes it more difficult for players (not impossible) to cheat on servers used for competitive play
[10:02] <denis> mainly, what i have against moving the check serverside, is that it makes servers impossible to debug
[10:02] <denis> someone comes into #odamex and says they can't connect to server xyz
[10:02] <denis> because their wad doesn't match
[10:03] <denis> and we won't be able to do anything, because we don't know what md5 the server wants
[10:04] <&#64;Ralphis> have the server print the MD5 to client
[10:04] <denis> that's what it currently does :)
[10:05] <denis> or we could do one MD5 forward and one MD5 of the reverse of the file
[10:05] <denis> so the forward MD5 is known to the client and server, but the reverse MD5 is known only to server
[10:06] <denis> (and client, assuming they actually have the correct wad)

Comment 2 Ralph Vickers 2011-08-15 17:16:59 CDT

Servers are definitely checking these wads now and have been for a long time.

Comment 3 Ralph Vickers 2011-08-16 21:39:40 CDT

Apparently I was WRONG. Reopening

Comment 4 Mike Lightner 2011-09-17 13:12:35 CDT

Is it more accurate to say it's not checking odamex.wad?  There's definitely some checking happening on the iwad and pwads.

Comment 5 Ralph Vickers 2012-04-13 08:28:52 CDT

*** Bug 774 has been marked as a duplicate of this bug. ***