Bug Tracker – Bug 665

Xbox: Launch parameters are not parsed if the Odamex path is too long

Last modified: 2010-10-23 03:24:20 UTC
Bug 665 - Xbox: Launch parameters are not parsed if the Odamex path is too long
Summary: Xbox: Launch parameters are not parsed if the Odamex path is too long
Status: RESOLVED FIXED
Alias: None
Product: Odamex
Classification: Unclassified
Component: Client (show other bugs)
Version: (old) 0.5.0 - 0.5.5
Hardware: Xbox All
: P2 normal
Assignee: Odamex Bug Reporter
URL:
Depends on:
Blocks: 667
  Show dependency tree
 
Reported: 2010-10-02 23:28 UTC by Mike Wood
Modified: 2010-10-23 03:24 UTC (History)
0 users

See Also:

Attachments

Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wood 2010-10-02 23:28:46 UTC
If Odamex is placed in a path with too many characters (more than 64 characters with the drive letter replaced by the physical partition path) Odamex will not load selected wads, join servers, or otherwise handle any launch parameters. This is due to the fact that the launcher path exceeds the limits of the launch data structure that the path is contained in which causes any attempt to determine the launcher xbe's TitleID to fail. The TitleID is used to verify that Odamex was launched by our launcher making it safe to parse the parameters. If the proper ID is not provided it is assumed that Odamex was launched from a dashboard and no attempt is made to parse parameters. The solution will require a change in Agar as well as Odamex and will involve the use of a custom structure with the path fields having a reasonable size.
Comment 1 Mike Wood 2010-10-23 03:24:20 UTC
Fixed in r1978.