Bug Tracker – Bug 887

Texture errors (e.g. if wrong IWAD is specified) shouldn't be fatal

Last modified: 2013-12-05 19:08:25 UTC
Bug 887 - Texture errors (e.g. if wrong IWAD is specified) shouldn't be fatal
Summary: Texture errors (e.g. if wrong IWAD is specified) shouldn't be fatal
Status: NEW
Alias: None
Product: Odamex
Classification: Unclassified
Component: Server & Client (show other bugs)
Version: (old) 0.6.x
Hardware: All Windows (Any)
: P1 normal
Assignee: Odamex Bug Reporter
URL:
Depends on:
Blocks:
 
Reported: 2012-07-31 19:37 UTC by Amateur Spammer
Modified: 2013-12-05 19:08 UTC (History)
2 users (show)

See Also:

Attachments

Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amateur Spammer 2012-07-31 19:37:43 UTC
After "wad doom zddl4.wad", client pops up an error dialog
---------------------------
Odamex Error
---------------------------
342 errors in R_InitTextures.
SDL_GetError = 
---------------------------
ОК   
---------------------------

 and terminates.
The server outputs lots of error messages and crashes.
Comment 1 Ralph Vickers 2012-07-31 19:50:14 UTC
Would you consider this incorrect behavior? This happens almost anytime a pwad designed for Doom 2 is attempted to be used with Doom 1 due to different TEXTURE1 lumps. What behavior should actually occur?
Comment 2 Amateur Spammer 2012-07-31 19:57:07 UTC
I agree, but it shouldn't crash at least. Crashing may be acceptable if server couldn't change the wads on the fly, as you would need a restart yo change them anyway. Also, server seemingly has no business loading textures.
Comment 3 Dr. Sean 2012-07-31 20:07:33 UTC
That is a good point about the server not loading texture resources. I might be mistaken but I seem to recall that a texture's bitmap data is not loaded until it's actually necessary to draw that texture on the screen. The textures definition is read when loading the wad and it is checked for errors but reading bitmap data is postponed (and not done for the server).
Comment 4 Dr. Sean 2013-12-05 19:08:25 UTC
This is fixed in the texmanager branch, which will eventually be moved into trunk. Missing patches do not cause a crash when composing a wall texture from patches. The default texture (a checkerboard pattern) is substituted for missing textures.