Bug Tracker – Bug 907

Odamex Incorrectly Identifies FREEDOOM.WAD as a commercial wad and will refuse to download it.

Last modified: 2016-10-14 23:43:03 UTC
Bug 907 - Odamex Incorrectly Identifies FREEDOOM.WAD as a commercial wad and will refuse to download it.
Summary: Odamex Incorrectly Identifies FREEDOOM.WAD as a commercial wad and will refus...
Status: NEW
Alias: None
Product: Odamex
Classification: Unclassified
Component: Server & Client (show other bugs)
Version: (old) 0.6.x
Hardware: All All
: P2 minor
Assignee: Odamex Bug Reporter
URL:
: 1165 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-10-03 00:40 UTC by RedZTag
Modified: 2016-10-14 23:43 UTC (History)
3 users (show)

See Also:

Attachments

Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description RedZTag 2012-10-03 00:40:50 UTC
https://sites.google.com/site/jostol27/Odamex_SOLO_20121003_133340.bmp
As you can see, Odamex refuses to transfer.
Comment 1 Alexander Mayfield 2012-10-11 23:15:30 UTC
This is due to the fact that Odamex uses W_IsIWAD() to determine if the file is okay to download which will return true for all IWAD's, not just commercially available ones.

A robust solution would be to make that check more nuanced.  Instead of returning a simple true and false, it could perhaps return a pointer to the appropriate doomwadnames entry on success, or a null pointer on failure.  The doomwadnames array could then be expanded to have more robust information, such as if the IWAD should be downloadable.

I seem to also have some memory of the canonical Freedoom WAD names being the same as the commercial WAD names.  If that's the case, we should probably also handle that case properly.
Comment 2 RedZTag 2012-10-17 04:51:58 UTC
Freedoom does name itself doom2.wad, and I assume ultimate freedoom will also name itself doom.wad.
Comment 3 /usr/share 2012-12-03 18:06:28 UTC
Probably the better way would be to check the wad against a checksum database of known commercial WADs (to check for different release versions of the WADs).
Comment 4 HeX_Vulture 2016-10-14 23:43:03 UTC
*** Bug 1165 has been marked as a duplicate of this bug. ***